Fix USB HID keyboard LED state reporting (#4162)#4338
Open
Caballosanex wants to merge 1 commit intoflipperdevices:devfrom
Open
Fix USB HID keyboard LED state reporting (#4162)#4338Caballosanex wants to merge 1 commit intoflipperdevices:devfrom
Caballosanex wants to merge 1 commit intoflipperdevices:devfrom
Conversation
Add missing OUT endpoint to USB HID keyboard interface so the host can send LED state reports (CapsLock, NumLock, ScrollLock) to the device. This makes furi_hal_hid_get_led_state() return the actual host LED state instead of always returning 0.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add missing OUT endpoint to USB HID keyboard interface so the host can send LED state reports (CapsLock, NumLock, ScrollLock) to the device. This makes
furi_hal_hid_get_led_state()return the actual host LED state instead of always returning 0.Closes #4162
Closes #4214
What's new
hid_txrx_ep_callback()but never fired since no OUT endpoint was registeredfuri_hal_usb_u2f.cwhich correctly declares both IN and OUT endpointsVerification
NUMLOCKdetection — Bad USB callsfuri_hal_hid_get_led_state()internally to check NumLock state. Before this fix, that check always returned 0.fapapp that callsfuri_hal_hid_get_led_state()after setting up USB HID withfuri_hal_usb_set_config(&usb_hid, NULL):furi_hal_hid_get_led_state()returns correct bitmask (0x01=NumLock, 0x02=CapsLock, 0x04=ScrollLock) instead of always 0Checklist (For Reviewer)